Maintained by: NLnet Labs

Fix dnstap relaying "random" messages instead of resolver/forwarder responses

W.C.A. Wijngaards
Tue Sep 27 13:57:32 CEST 2016


Hi Nikolay,

Thank you for the fix, it is integrated (but did not make into the just
release 1.5.10 release).

Best regards, Wouter

On 27/09/16 08:25, Nikolay Edigaryev via Unbound-users wrote:
> This was already fixed for serviced_tcp_callback() in revision 3390, but
> for some reason serviced_udp_callback() left untouched.
> 
> Index: services/outside_network.c
> ===================================================================
> --- services/outside_network.c	(revision 3866)
> +++ services/outside_network.c	(working copy)
> @@ -1879,7 +1879,7 @@
>  		return 0;
>  	}
>  #ifdef USE_DNSTAP
> -	if(outnet->dtenv &&
> +	if(error == NETEVENT_NOERROR && outnet->dtenv &&
>  	   (outnet->dtenv->log_resolver_response_messages ||
>  	    outnet->dtenv->log_forwarder_response_messages))
>  		dt_msg_send_outside_response(outnet->dtenv, &sq->addr, c->type,
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://unbound.nlnetlabs.nl/pipermail/unbound-users/attachments/20160927/10380874/attachment.sig>